[FFmpeg-devel] [PATCH] lavd/oss: support for more than 2 channels

Nicolas George nicolas.george at normalesup.org
Sun Jul 22 17:26:26 CEST 2012

Le quintidi 5 thermidor, an CCXX, Reimar Döffinger a écrit :
> Could you please drop the attitude?
> He pointed out an actual bug (channels will play in the wrong order), do
> you seriously that bikeshed? Particularly since that bug means that the
> whole new feature you add is not working properly, not just some
> corner-case.
> If the noise bothers you, just make it bail out when it's > 2 channels,
> then someone motivated to implement it properly can do that later.

Thanks, I was being afraid I had been rude. Paul, please be sure I have
absolutely nothing against you and I only wrote my mails out of genuine
concern on the code quality and because I have been annoyed a lot by similar
problems in the past.

I am completely willing to implement a proper solution, but only when I am
able to reasonably test it (5.1 on OSS emulated by ALSA should be good
enough). Which, unfortunately, means not sooner than September because I am
far away from my surround speakers.

In the meantime, I can propose the attached patch, to make things clearer.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-oss-error-out-for-multichannel-init.patch
Type: text/x-diff
Size: 1063 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120722/810c95bd/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120722/810c95bd/attachment.asc>

More information about the ffmpeg-devel mailing list