[FFmpeg-devel] [PATCH] [RFC] avoid _vscnprintf since it exists only since WinXP.
Reimar.Doeffinger at gmx.de
Sun Jul 22 21:53:21 CEST 2012
On Sun, Jul 22, 2012 at 03:38:43PM -0400, Derek Buitenhuis wrote:
> On 22/07/2012 3:05 PM, Reimar Döffinger wrote:
> > The MSDN documentation is wrong, this function does not exist
> > on e.g. Win2k.
> > By my reading of the only case where it is used, this hack should work
> > almost as well, though it is ugly and comes with a risk of breaking
> > in the future.
> Why? Do we really support OSes that MS doesn't even support anymore?
Well, I see no reason not to try.
> If someone is using Win2k, they're already using an unsupported OS that
> things will likely not work on. Adding this sort of thing for such a
> purpose is just silly.
Well, it actually removes some code that seems completely unnecessary.
To I believe the code would be nicer and simpler if it didn't rely on
the vsnprintf return value at all, or at least used it only as a hint.
> "Bawwwwwww this binary won't work on my OS from 12 years ago that isn't
> even supported by it's author!"
There's no need to be insulting. Obviously people are still using it,
and while I don't see them seriously complaining (reporting it seems
very reasonable since the MSDN docs are wrong) that's no reason
to not discuss simple solutions.
And we do support e.g. OS/2, BeOS/Haiku and a lot of other stuff that
I'm sure has fewer users than Win2k (there's a good chance there's
actually fewer Linux users out there than people using a Windows before
More information about the ffmpeg-devel