[FFmpeg-devel] [PATCH 1/2] faq: disambiguate "join".

Alexander Strasser eclipse7 at gmx.net
Tue Jul 24 00:57:29 CEST 2012

Hi Nicolas,

  just a few (nit) comments. I like the clarification and additional
documentation. Consider to address my comments depending on your
motivation and agreement.

Nicolas George wrote:
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  doc/faq.texi |   45 ++++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 42 insertions(+), 3 deletions(-)
> diff --git a/doc/faq.texi b/doc/faq.texi
> index d10faa1..93ba105 100644
> --- a/doc/faq.texi
> +++ b/doc/faq.texi
> @@ -213,8 +213,46 @@ For ANY other help on Avisynth, please visit the
>  @section How can I join video files?
> -A few multimedia containers (MPEG-1, MPEG-2 PS, DV) allow to join video files by
> -merely concatenating them.
> +To "join" video files is quite ambiguous. Using accurate words will make
> +finding resources easier. To join video files may mean:

  IMHO sounds a bit too teacher-like (sorry, really no pun intended). Maybe:

    To "join" video files is quite ambiguous. The following list explains
    the different kinds of "joining" and points out how those are addressed
    in FFmpeg. To join video files may mean:

Or similar. No strong opinion on this one...

> +
> + at itemize
> +
> + at item
> +To put them one after the other: this is called to @emph{concatenate} them
> +(in short: concat) and is addressed

  Is there a preposition missing between above and below? "in"?

> + at ref{How can I concatenate video files, in this very faq}.

> +
> + at item
> +To put them together in the same file, to let the user choose between the
> +different versions (example: different audio languages): this is called to
> + at emph{multiplex} them together (in short: mux), and is done by simply using
> +several @option{-i} options to ffmpeg.

  "using ... options to ffmpeg" sounds odd. Maybe  "giving ... options to",
or "invoking ffmpeg with ... options".

  Maybe native English speakers can clarify. I am not so please take my
comments with a grain of salt.


Good work on making the FAQ more useful,

More information about the ffmpeg-devel mailing list