[FFmpeg-devel] [PATCH 3/5] mp3dec: parse initial silence padding information from lame tag

Nicolas George nicolas.george at normalesup.org
Tue Jul 24 14:12:13 CEST 2012

Le septidi 7 thermidor, an CCXX, Michael Niedermayer a écrit :
> This is a regresion since this commit or "commit 885fc058655efee94203314984ce99b301fdebb1
>     lavf: count skipped samples for initial timestamps.
>     If skip_samples is set and timestamps are synthesized using durations,
>     make them start at -skip_samples (rescaled) instead of 0,
>     so that the timestamp of the first undiscarded sample is 0.
> -----------
> Ill look into it after a few hours of sleep, unless nicolas has time
> before to investigate

I tried to investigate after a few hours of sleep too, but did not manage
much. The core of it seems to be that the timestamps are inserted into the
index before the -skip_samples shift could kick in, because there are
several places where relative timestamps are turned to absolute.

The whole timestamp system is still too complex for me, I did not manage to
find a robust solution.

I am not opposed to just reverting this commit as a bad idea.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120724/afd4ba77/attachment.asc>

More information about the ffmpeg-devel mailing list