[FFmpeg-devel] [PATCH 3/5] mp3dec: parse initial silence padding information from lame tag
michaelni at gmx.at
Tue Jul 24 17:19:27 CEST 2012
On Tue, Jul 24, 2012 at 02:12:13PM +0200, Nicolas George wrote:
> Le septidi 7 thermidor, an CCXX, Michael Niedermayer a écrit :
> > This is a regresion since this commit or "commit 885fc058655efee94203314984ce99b301fdebb1
> > lavf: count skipped samples for initial timestamps.
> > If skip_samples is set and timestamps are synthesized using durations,
> > make them start at -skip_samples (rescaled) instead of 0,
> > so that the timestamp of the first undiscarded sample is 0.
> > -----------
> > Ill look into it after a few hours of sleep, unless nicolas has time
> > before to investigate
> I tried to investigate after a few hours of sleep too, but did not manage
> much. The core of it seems to be that the timestamps are inserted into the
> index before the -skip_samples shift could kick in, because there are
> several places where relative timestamps are turned to absolute.
> The whole timestamp system is still too complex for me, I did not manage to
> find a robust solution.
> I am not opposed to just reverting this commit as a bad idea.
ok then ill revert it until a solution is found
ive also found a few related issues while looking into this, ill post
a patchset that fixes these related issues once iam happy with it
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel