[FFmpeg-devel] [PATCH] riff: make the G723.1 in wav outputcompatible with WMP/msacm codec

Michael Niedermayer michaelni at gmx.at
Tue Jul 24 22:22:19 CEST 2012


On Tue, Jul 24, 2012 at 09:14:50PM +0200, Piotr Bandurski wrote:
> Hi,
> 
> > > + } else if (enc->codec_id == CODEC_ID_G723_1) {
> > > + bytespersec = 800;
> > > } else {
> > > bytespersec = enc->bit_rate / 8;
> > > }
> > 
> > g723.1 supports multiple bitrates, is this correct for all ?
> 
> MS codec have two modes for encoding - 6400 bit/s and 5333 bit/s.
> 
> It looks like for 6400 mode blkalign is set to 24, bytespersec is set to 800,
> for 5333 mode - blkalign is set to 20, bytespersec is set to 666, but the output
> files have the same size and are identical if we do not count these two different
> values in the wav header.

so your patch works with both ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120724/e830f33e/attachment.asc>


More information about the ffmpeg-devel mailing list