[FFmpeg-devel] [PATCH 10/15] g723_1: Fix warning about discarded qualifier

Michael Niedermayer michaelni at gmx.at
Fri Jul 27 12:14:26 CEST 2012


On Fri, Jul 27, 2012 at 05:23:20AM -0300, jamal wrote:
> ---
>  libavcodec/g723_1.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/libavcodec/g723_1.c b/libavcodec/g723_1.c
> index c7f6ac9..06f53f5 100644
> --- a/libavcodec/g723_1.c
> +++ b/libavcodec/g723_1.c
> @@ -2138,7 +2138,7 @@ static int g723_1_encode_frame(AVCodecContext *avctx, AVPacket *avpkt,
>      int16_t weighted_lpc[LPC_ORDER * SUBFRAMES << 1];
>      int16_t vector[FRAME_LEN + PITCH_MAX];
>      int offset, ret;
> -    int16_t *in = (const int16_t *)frame->data[0];
> +    int16_t *in = (int16_t *)frame->data[0];

this is wrong, the encoder input is constant, the code is changing it
thats is a bug which the warning points to.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120727/a78d54a3/attachment.asc>


More information about the ffmpeg-devel mailing list