[FFmpeg-devel] [PATCH] asrc_flite: do not crash on multiple instances.

Nicolas George nicolas.george at normalesup.org
Sat Jul 28 15:33:07 CEST 2012

Le primidi 11 thermidor, an CCXX, Stefano Sabatini a écrit :
> > The second is problem is solved by keeping an usage counter inside
>              ^^


> Now redundant? Could be dropped in favor of voice_entry.

Possible, but that would make the patch more complex. I can do it separately
if you want, but I am not sure this is such a good idea: it means exposing
the workaround throughout the code.

> Nit++:
> #define MAKE_VOICE_STRUCTURE(voice_name) {                 \
>       .name          =                      #voice_name,   \
>       .register_fn   =   register_cmu_us_ ## voice_name,   \
>       .unregister_fn = unregister_cmu_us_ ## voice_name,   \
> }

Nicer indeed.

> Sounds OK otherwise, thank you.

Thanks for the review, pushed, along with fixes to concat.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120728/45d0631d/attachment.asc>

More information about the ffmpeg-devel mailing list