[FFmpeg-devel] [PATCH 2/2] ffprobe: refactor frames decoding.
nicolas.george at normalesup.org
Sun Jul 29 16:10:31 CEST 2012
L'octidi 8 thermidor, an CCXX, Stefano Sabatini a écrit :
> process_decoded_frame -> process_frame
> the latter is simpler and seems less misleading (since the frame is
> not yet decoded)
> > + while (pkt1.size &&
> > + process_decoded_frame(w, fmt_ctx, &frame, &pkt1) > 0);
> nit: maybe drop "> 0".
process_(decoded)_frame() returning 0 means stop too, just not an error.
> Now this is doing:
> pkt->data += ret;
> pkt->size -= ret;
> and pkt->data is NULL.
> Verify that the decoder is returning 0 when the data is flushed (as I
> suppose it does).
The last patch of the patchset I just sent addresses that.
> Looks good otherwise, thanks.
Thanks, I'll push when the previous patch is updated.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel