[FFmpeg-devel] [PATCH 11/19] 8svx: remove useless rounding code.

Paul B Mahol onemda at gmail.com
Sun Jul 29 17:04:33 CEST 2012

On 7/29/12, Nicolas George <nicolas.george at normalesup.org> wrote:
> Le duodi 12 thermidor, an CCXX, Paul B Mahol a ecrit :
>> > samples_size and samples_idx are supposed to be multiple of
>> > channels at all time. If they are, the division is exact;
>> > if they are not, something is very wrong in the code.
>> In which case assert would notify us that something got wrong.
>> So I would keep assert.
> I am not sure I understand you correctly: adding an assert to check that
> the
> division is exact is one of the things this patch does. Do you want that
> fact added to the commit message?

Obviously I got it wrong, so patch is OK.

More information about the ffmpeg-devel mailing list