[FFmpeg-devel] [PATCH] lavc: add channels field to AVFrame

Stefano Sabatini stefasab at gmail.com
Mon Jul 30 19:03:23 CEST 2012


On date Monday 2012-07-30 18:49:32 +0200, Michael Niedermayer encoded:
> On Mon, Jul 30, 2012 at 04:11:36PM +0200, Stefano Sabatini wrote:
> > This is required otherwise it is not always possible to guess the number
> > of channels from the layout, for example if the channel layout is
> > unknown.
> > ---
> >  libavcodec/avcodec.h |   11 +++++++++++
> >  libavcodec/utils.c   |    4 ++++
> >  2 files changed, 15 insertions(+), 0 deletions(-)
> 
> LGTM
> 
> thanks

Nit: should be nb_channels (more meaningful, consistent with
nb_samples) or channels (consistent with AVCodecContext)?

I'm not still sure it is a good idea to propagate the info to lavfi
(since we may require that the channel layout is always set inside the
filtergraph), but this patch seems useful on its own and shouldn't
hurt anyway.
-- 
FFmpeg = Faithful & Fiendish Multimedia Powerful Encoding/decoding Gigant


More information about the ffmpeg-devel mailing list