[FFmpeg-devel] [PATCH 1/4] wmaprodec: fix return value for too small packets.

Michael Niedermayer michaelni at gmx.at
Tue Jul 31 19:06:16 CEST 2012


On Tue, Jul 31, 2012 at 06:59:48PM +0200, Michael Niedermayer wrote:
> On Tue, Jul 31, 2012 at 06:56:22PM +0200, Michael Niedermayer wrote:
> > On Tue, Jul 31, 2012 at 06:34:43PM +0200, Nicolas George wrote:
> > > 
> > > Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> > > ---
> > >  libavcodec/wmaprodec.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > LGTM
> 
> rethinking & rereading the code i withdraw this "LGTM", i dont think
> this should be an error condition

IMHO the decoder should just decode the packet no matter what size it
has


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120731/6657489e/attachment.asc>


More information about the ffmpeg-devel mailing list