[FFmpeg-devel] [PATCH 1/4] wmaprodec: fix return value for too small packets.

Nicolas George nicolas.george at normalesup.org
Tue Jul 31 19:28:48 CEST 2012


Le quartidi 14 thermidor, an CCXX, Michael Niedermayer a écrit :
> IMHO the decoder should just decode the packet no matter what size it
> has

Maybe that would be better, but that is not what it currently does, and
changing its behaviour is way beyond my knowledge of that codec. The purpose
of this patch was only to avoid returning 0 (success) when no progress was
done at all nor can be done.

But maybe that kind of behaviour is helpful for applications that do not use
lavf and rely on avcodec_decode_audio4() to also detect packets boundaries?
In that case, I shall leave it as is and adjust the asserts/checks I
proposed in avcodec_decode_audio4() accordingly.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120731/3202f11f/attachment.asc>


More information about the ffmpeg-devel mailing list