[FFmpeg-devel] [PATCH] ffmpeg: Set duration on encoded subtitle packets.

[Michael Niedermayer]

On Wed, Jun 06, 2012 at 09:30:07AM -0700, Philip Langdale wrote:
> On Sun, 3 Jun 2012 14:20:07 -0700
> Philip Langdale <philipl at overt.org> wrote:
> 
> > On Sun, 3 Jun 2012 21:08:40 +0200
> > Clément Bœsch <ubitux at gmail.com> wrote:
> > 
> > > 
> > > MicroDVD demuxer is making use of that duration field; are you sure
> > > it doesn't break anything to override it?
> > > 
> > > (Common scenario: ffmpeg -i microdvd.sub out.ass, see 2d52ee8a for
> > > more information)
> > 
> > Your example is on the decoder side. I'm talking about the encoder.
> > Today, 'ffmpeg' will always pass subtitle packets to the muxer with
> > no duration - and we have got away with this because the muxers don't
> > require packet duration for the formats we supporClémentt (eg: the
> > muxer parses srt and ass packets to get the duration). For timed text,
> > there's no side-band way to pass duration, so we have to do it
> > properly on the packet.
> 
> Clément let me know that he's happy with this change off-list.

ok, applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120606/882c62d7/attachment.asc>