[FFmpeg-devel] [PATCH] lavfi/audio: fix size of copied samples.
nicolas.george at normalesup.org
Thu Jun 7 17:20:21 CEST 2012
Le nonidi 19 prairial, an CCXX, Michael Niedermayer a écrit :
By the way, Stefano, I would appreciate if you could explain me is someone
is doing something wrong here:
aresample requests a buffer with permission AV_PERM_WRITE.
amerge does not implement get_audio_buffer, so the buffer is mallocated.
aresamples fills the buffer and then gives it, the only reference, to
amerge asks for AV_PERM_READ | AV_PERM_PRESERVE on its inputs.
Since the buffer does not have AV_PERM_PRESERVE, ff_filter_samples decides
to make a copy (thus triggering the bug this commit fixes).
As far as I can see, there is no need to make a copy, so something must be
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel