[FFmpeg-devel] [PATCH] lavfi/audio: fix size of copied samples.

[Nicolas George]

Le nonidi 19 prairial, an CCXX, Michael Niedermayer a écrit :
> LGTM

Thanks, pushed.

By the way, Stefano, I would appreciate if you could explain me is someone
is doing something wrong here:

aresample requests a buffer with permission AV_PERM_WRITE.

amerge does not implement get_audio_buffer, so the buffer is mallocated.

aresamples fills the buffer and then gives it, the only reference, to
amerge.

amerge asks for AV_PERM_READ | AV_PERM_PRESERVE on its inputs.

Since the buffer does not have AV_PERM_PRESERVE, ff_filter_samples decides
to make a copy (thus triggering the bug this commit fixes).

As far as I can see, there is no need to make a copy, so something must be
wrong somewhere.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120607/fb8050d5/attachment.asc>