[FFmpeg-devel] [PATCH] bprint: implement vsnprintf for win32.

Alexander Strasser eclipse7 at gmx.net
Fri Jun 15 01:27:16 CEST 2012


Hi,

Nicolas George wrote:
> Le septidi 27 prairial, an CCXX, Michael Niedermayer a écrit :
> > LGTM
> 
> Thanks, pushed.

  sorry for joining in late. I did not look up what this is
about. But IMHO the commit message was definitely lacking.
I apologize if this was pushed with a better message.

  It is very good to summarize the change as you did in the
subject, but in this case you IMHO definitely need to add a
larger message body explaining the motivation and why this
should fix the problem you noticed (on FATE).

  This is not meant to discourage you or anyone, I do very
much appreciate your work! Also talk is cheap and I know
I am late to complain, so please forgive my whining.

  Alexander


More information about the ffmpeg-devel mailing list