[FFmpeg-devel] [PATCH] bprint: implement vsnprintf for win32.

Alexander Strasser eclipse7 at gmx.net
Fri Jun 15 17:29:57 CEST 2012


Nicolas George wrote:
> L'octidi 28 prairial, an CCXX, Alexander Strasser a écrit :
> >   sorry for joining in late. I did not look up what this is
> > about. But IMHO the commit message was definitely lacking.
> > I apologize if this was pushed with a better message.
> > 
> >   It is very good to summarize the change as you did in the
> > subject, but in this case you IMHO definitely need to add a
> > larger message body explaining the motivation and why this
> > should fix the problem you noticed (on FATE).
> > 
> >   This is not meant to discourage you or anyone, I do very
> > much appreciate your work! Also talk is cheap and I know
> > I am late to complain, so please forgive my whining.
> No problem. I hesitated to be more verbose in the commit message. If you
> want, I can add a comment near the additional code:
> /* Windows's snprintf returns -1 if the buffer is not large enough,
>    the standard requires the number of bytes that would have been used.
>    _vscprintf computes that number of bytes. */
> If you agree and no one objects, I can push it directly.

  Fine with me. Thank you for revisiting that change!

  Nit: I am not entirely sure but I think the last s in "Windows's"
should be omitted. Also the snprintf should probably read vsnprintf.


More information about the ffmpeg-devel mailing list