[FFmpeg-devel] [PATCH] lavfi/avcodec: add consistency checks in avfilter_copy_buf_props()

[Stefano Sabatini]

On date Friday 2012-06-15 02:27:03 +0200, Michael Niedermayer encoded:
> On Thu, Jun 14, 2012 at 11:39:15PM +0200, Stefano Sabatini wrote:
> > On date Wednesday 2012-06-13 11:36:05 +0200, Michael Niedermayer encoded:
> > > On Wed, Jun 13, 2012 at 10:59:13AM +0200, Stefano Sabatini wrote:
> > [...]
> > > > I'm unsure about what to do with the type inconsistency cases (VIDEO
> > > > && !ref->video), maybe should I add an assert as well there?
> > > 
> > > if theres no legitimate case where that can happen then it should be
> > > better to assert()
> > [...]
> > 
> > Upped.
> > -- 
> > FFmpeg = Freak & Fancy Mournful Power Emblematic Game
> 
> >  avcodec.c |    8 ++++++++
> >  1 file changed, 8 insertions(+)
> > d8274f1298a76db7928714e92b1a418ac5664e75  0003-lavfi-avcodec-add-consistency-checks-in-avfilter_cop.patch
> > From bf6ea6e6270501403f1864f233b4145503ecce4c Mon Sep 17 00:00:00 2001
> > From: Stefano Sabatini <stefasab at gmail.com>
> > Date: Sun, 10 Jun 2012 18:17:50 +0200
> > Subject: [PATCH] lavfi/avcodec: add consistency checks in
> >  avfilter_copy_buf_props()
> > 
> > The function will abort through an assert if the source is not defined,
> > or if the internal state of the source is inconsistent (e.g. type = AUDIO
> > && !src->audio).
> 
> LGTM

Applied.
-- 
FFmpeg = Funny Fascinating Magic Prodigious Enigmatic God