[FFmpeg-devel] [PATCH] matroskadec: set duration also for subtitles.

Philip Langdale philipl at overt.org
Sun Jun 17 22:48:40 CEST 2012

On Sun, 17 Jun 2012 22:21:40 +0200
Nicolas George <nicolas.george at normalesup.org> wrote:

> Le decadi 30 prairial, an CCXX, Hendrik Leppkes a écrit :
> > AFAIK, convergence_duration is used because its int64 and duration
> > only int. On some matroska time bases the duration of a subtitle
> > packet (multiple seconds) can manage to overflow the 32bit duration.
> > 
> > At least thats the only useful reason i remember.
> Thanks for the information. In that case, we should consider this
> patch aborted, and maybe document the abuse of the
> convergence_duration field.

Ugh. This complicates things a fair bit. Should we just standardize
on convergence_duration for all subtitle AVPackets then? It'll suck
to have to check both fields everywhere.


More information about the ffmpeg-devel mailing list