[FFmpeg-devel] [PATCH] lavf: add a real SRT muxer.

[Clément Bœsch]

On Thu, Jun 21, 2012 at 07:33:27PM +0200, Nicolas George wrote:
> Le quartidi 4 messidor, an CCXX, Clément Bœsch a écrit :
> > The point was just to avoid the write_ts assignment each time, like if it
> > was suggesting it could change between srt_write_packet() calls (or can
> > it?).
> 
> It is suggesting nothing of the sort, it is just reducing code duplication.
> Nobody would have said anything if I had included the same test in both.
> 

Ah, I see the meaning then. I was just defending the fact that having an
explicit constant muxer state from the beginning ("init the muxer: will
this muxer write the TS or not?") avoid the questioning about why this
check is done each time in srt_write_packet().

Of course this is just bikeshed, just clarifying my thoughts.

> > If it detects the "<num>\n... --> ..." form in the packet, it could assume
> > one mode or another. That might sound hacky though :)
> 
> And also fragile. And even bogus: a subtitle text is allowed to look exactly
> like a SRT timestamp.
> 

Yep. The purpose was mainly in the spirit of not breaking tools using the
API with or without that information. But this is just science fiction :-)

> If you or others have no objections, I shall push the patch as is soon.
> 

No objection from me really.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120621/c46e4a49/attachment.asc>