[FFmpeg-devel] [PATCH 2/4] lavfi: add audioframe helper functions.

Michael Niedermayer michaelni at gmx.at
Fri Jun 29 17:31:31 CEST 2012


On Fri, Jun 29, 2012 at 05:13:14PM +0200, Nicolas George wrote:
> Le duodi 12 messidor, an CCXX, Clément Bœsch a écrit :
> > Could we have this in libavutil instead?
> 
> I wrote that piece of code as a private helper, so not really considering
> API stability. At the very least it would need some more careful thought
> before being made public.
> 
> >					   Maybe in audio_fifo.c?
> 
> Speaking of audio_fifo, I really do not like this API. It does always two
> memory copies when almost always only one, possibly zero, would be possible.
> I believe we should mark it as deprecated.

i dont like audio_fifo either, for different reasons though, nameley
it is implemented on top of a thread safe fifo while it itself is not
thread safe and theres no reason at all to implement it that way

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120629/33079d8d/attachment.asc>


More information about the ffmpeg-devel mailing list