[FFmpeg-devel] [PATCH 2/2] libutvideo: Add Ut Video encoder wrapper

Michael Niedermayer michaelni at gmx.at
Sun Mar 4 05:32:39 CET 2012


On Sat, Mar 03, 2012 at 08:36:15PM -0500, Derek Buitenhuis wrote:
> On 03/03/2012 8:26 PM, Clément Bœsch wrote:
> >Please use the -M option for this, and mention it in the description.
[...]
> >>+    avctx->coded_frame->key_frame = keyframe ? 1 : 0;
> >>+    avctx->coded_frame->pict_type = AV_PICTURE_TYPE_I;
> >>+
> >>+    pkt->flags |= AV_PKT_FLAG_KEY;
> >
> >Is it intra only? If so, I wonder if you shouldn't update is_intra_only()
> >in libavformat/utils.c.
> 
> Yeah it is, and I should. I'll also add CODEC_CAP_LOSSLESS or whatever
> the relevant capability is, which I just realized I forgot.
> 
> I'll send a v2 patch once Michael, and whoever else wants to, reviews
> it.

no need to wait for me, ubitux already did a pretty complete review.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120304/e5d06f0d/attachment.asc>


More information about the ffmpeg-devel mailing list