[FFmpeg-devel] [PATCH 1/4] vf_fspp: fix compilation with llvm

[Reimar Döffinger]

On Sat, Mar 10, 2012 at 08:22:33AM +0100, Michael Niedermayer wrote:
> From: Baptiste Coudurier <baptiste.coudurier at gmail.com>
> 
> ---
>  libavfilter/libmpcodecs/vf_fspp.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavfilter/libmpcodecs/vf_fspp.c b/libavfilter/libmpcodecs/vf_fspp.c
> index a98c70b..af50c6b 100644
> --- a/libavfilter/libmpcodecs/vf_fspp.c
> +++ b/libavfilter/libmpcodecs/vf_fspp.c
> @@ -710,8 +710,8 @@ const vf_info_t vf_info_fspp = {
>  #if HAVE_MMX
>  
>  DECLARE_ASM_CONST(8, uint64_t, MM_FIX_0_382683433)=FIX64(0.382683433, 14);
> -DECLARE_ASM_CONST(8, uint64_t, MM_FIX_0_541196100)=FIX64(0.541196100, 14);
> -DECLARE_ASM_CONST(8, uint64_t, MM_FIX_0_707106781)=FIX64(0.707106781, 14);
> +DECLARE_ALIGNED(8, uint64_t, MM_FIX_0_541196100)=FIX64(0.541196100, 14);
> +DECLARE_ALIGNED(8, uint64_t, MM_FIX_0_707106781)=FIX64(0.707106781, 14);

Why is this necessary and why does it work?
If the __attribute__((used)) doesn't work for LLVM I still consider
it the "correct" solution to remove the static as done for ICC.
(might mean it is necessary to rename some of these to avoid symbol
collisions, but then again it might make sense to just make them
global with an ff_ prefix).
Since this change makes them global a ff_ prefix should be added anyway.