[FFmpeg-devel] Latest FFMPEG 0.9 Issues

[Michael Niedermayer]

On Sun, Mar 11, 2012 at 11:35:37PM -0700, Baptiste Coudurier wrote:
> On 12/31/11 8:23 AM, Michael Niedermayer wrote:
> > On Fri, Dec 30, 2011 at 09:52:21PM -0800, C Chatterjee wrote:
> >>
> >> Michael:
> >>
> >> Thanks for fixing the aacdec.c bug in item 1 below in an email sent by you earlier.
> >>
> >> On item 2 I believe that checking as below:
> >>      else if (enc->codec_id == CODEC_ID_AAC && pkt->size > 2 &&
> >>                 (AV_RB16(pkt->data) & 0xfff0) == 0xfff0) {
> >>          av_log(s, AV_LOG_ERROR, "malformated aac bitstream, use -absf aac_adtstoasc\n");
> >>          return -1;
> >> may not be necessary because the 2 byte header can be at the start of a payload too.
> >> I have used this stream on a number of players - VLC, Flash and iPhone. All works. 
> >> Is there a case of a player where it does not work.
> >> I comment out the lines above in flvenc.c and movenc.c and use ffmpeg as:
> >>
> >> ffmpeg -y -i xx.flv -acodec copy -vcodec -preset superfast -b:v 150k ff.flv
> >> ff.flv works fine on all players I have used.
> > 
> > hmm, maybe
> > baptiste, mike or alex could comment on if this check is or is not
> > required ?
> 
> The check is there to prevent muxing adts in flv, AFAIK flv requires raw aac.

do you know of some player that fails with adts or is there a spec
that says what is allowed to be put in flv ?


> Copying from flv to flv means copying raw aac to raw aac and should not trigger
> that problem unless xx.flv had already been wrongly muxed.
> 
> IMHO it is not a good idea to remove that check.

as said i can put it back ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120312/8a214459/attachment.asc>