[FFmpeg-devel] [vf_ass.c] 2 lines of code that need your attention

Michael Niedermayer michaelni at gmx.at
Fri Mar 16 04:40:58 CET 2012


On Fri, Mar 16, 2012 at 10:03:29AM +0800, REN Lifeng wrote:
> Hi developer of the ASS/SSA video filter,
> 
> I found 2 places that need your attention.
> 
> 1. division of int or float
> 
> 137:    double dar = inlink->w / inlink->h * sar;
> 
> Suppose w is 640 h is 272 and sar is 1.0, dar will be 2.0 instead of
> 2.3529.

fixed


> 
> 2. aspec ratiot of video  v.s. aspect ratio of display

ill leave this for our vf_ass experts to look into.

Thanks

PS: if you want to submit code changes for inclusion in ffmpeg please
consider using git format-patch / send-email.


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120316/ec7c9e11/attachment.asc>


More information about the ffmpeg-devel mailing list