[FFmpeg-devel] [PATCH] pixdesc: put components always in the same order.
michaelni at gmx.at
Sun Mar 18 18:29:27 CET 2012
On Sun, Mar 18, 2012 at 03:28:36PM +0100, Stefano Sabatini wrote:
> On date Sunday 2012-03-18 10:15:36 +0100, Nicolas George encoded:
> > Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> > ---
> > libavutil/pixdesc.c | 94 +++++++++++++++++++++++++-------------------------
> > libavutil/pixdesc.h | 9 +++--
> > 2 files changed, 53 insertions(+), 50 deletions(-)
> > It does not seem to have any advert effect (on FATE anyway; I can run more
> > tests if necessary) and it makes the table much more useful.
> It looks a good idea to me, and no from what I know current code never
> assumes the order of component colors so there should be no
> regression, but wait a comment from Michael.
if the patch doesnt break anything then iam fine with it
> I just note that originally pixdesc was designed to be colorspace
> independent, now with the RGB flag things are getting a bit different
> (for example what about YUV/YUVJ? - this would almost allow to kill
The colorspace is described by
AVColorPrimaries, AVColorTransferCharacteristic, AVColorSpace,
it would be somewhat difficult to store this in the pixfmt enum
if we look just at YUV/YUVJ compare to AVColorRange, later has a 3rd
"dont know" case. Its certainly possibly (just think of RAW) that its
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel