[FFmpeg-devel] [PATCH] mxf: micro patch - mxf parsing

Tomas Härdin tomas.hardin at codemill.se
Tue Mar 20 11:46:59 CET 2012


On Mon, 2012-03-19 at 17:06 +0200, Alex Zhukov wrote:
> On Mon, Mar 19, 2012 at 4:02 PM, Alex Zhukov <zhukov.alex at gmail.com> wrote:
> > On Mon, Mar 19, 2012 at 2:12 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> On Fri, Mar 16, 2012 at 08:47:59PM +0200, Alex Zhukov wrote:
> >>> I thought this fix was not worth creating the full on patch
> >>> make fate fails on adpcm_ima_qt for me so did not test
> >>>
> >>> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> >>> index 3d99ea7..e2eea95 100644
> >>> --- a/libavformat/mxfdec.c
> >>> +++ b/libavformat/mxfdec.c
> >>> @@ -1877,6 +1877,7 @@ static int mxf_read_header(AVFormatContext *s)
> >>>              /* next partition pack - keep going, seek to previous
> >>> partition or stop */
> >>>              if(mxf_parse_handle_partition_or_eof(mxf) <= 0)
> >>>                  break;
> >>> +            continue;
> >>>          }
> >>
> >> this patch seems to break fate-seek-lavf_mxf
> >
> > yes it does
> > let me figure out why
> 
> I was trying to fix ticket https://ffmpeg.org/trac/ffmpeg/ticket/1099
> Maybe mxf maintainer could take a look.

Here's a better patch that fixes the issue and doesn't break FATE.

/Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mxfdec-Only-parse-next-partition-pack-if-parsing-for.patch
Type: text/x-patch
Size: 1012 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120320/3f1f6eac/attachment.bin>


More information about the ffmpeg-devel mailing list