[FFmpeg-devel] [PATCH 2/3] LucasArts SMUSH video decoder

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Mar 27 21:42:01 CEST 2012

too much to review right now, but

On Tue, Mar 27, 2012 at 05:28:44PM +0000, Paul B Mahol wrote:
> +static void make_glyphs(int8_t *pglyphs, const int8_t *xvec, const int8_t *yvec,
> +                        const int side_length)

IMO these glyph related functions really need some (doxy) comments to
give an idea what they are doing.
Where you know or can guess that applies to the individual decode
functions, too.

More information about the ffmpeg-devel mailing list