[FFmpeg-devel] [PATCH 17/17] lavu/error: fix make checkheaders.
michaelni at gmx.at
Wed May 9 14:56:42 CEST 2012
On Wed, May 09, 2012 at 01:18:56PM +0200, Clément Bœsch wrote:
> On Wed, May 09, 2012 at 12:43:56PM +0200, Michael Niedermayer wrote:
> > On Wed, May 09, 2012 at 10:01:42AM +0200, Clément Bœsch wrote:
> > > From: Clément Bœsch <clement.boesch at smartjog.com>
> > >
> > > The errors need to be defined before including functions depending on
> > > them. See av_size_mult() for instance.
> > > ---
> > > libavutil/error.h | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/libavutil/error.h b/libavutil/error.h
> > > index 3b05e4b..6a7eec6 100644
> > > --- a/libavutil/error.h
> > > +++ b/libavutil/error.h
> > > @@ -25,7 +25,6 @@
> > > #define AVUTIL_ERROR_H
> > >
> > > #include <errno.h>
> > > -#include "avutil.h"
> > probably should be include stddef.h or so
> I included unistd.h at first (for the size_t in the prototype below), but
> it conflicted with too much internal symbols (like sync() or close())
> so I thought it wasn't that a good idea.
iam not sure why you would include unistd.h ...
7.17 Common definitions <stddef.h>
1 The following types and macros are defined in the standard header <stddef.h>. Some
are also defined in other headers, as noted in their respective subclauses.
2 The types are
which is the signed integer type of the result of subtracting two pointers;
which is the unsigned integer type of the result of the sizeof operator; and
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Old school: Use the lowest level language in which you can solve the problem
New school: Use the highest level language in which the latest supercomputer
can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel