[FFmpeg-devel] [PATCH] ffprobe: simplify/fix logic for the -show_format_entry option

Stefano Sabatini stefasab at gmail.com
Sat May 12 14:43:14 CEST 2012


On date Thursday 2012-05-10 01:40:36 +0200, Stefano Sabatini encoded:
> On date Wednesday 2012-05-09 16:35:23 +0200, Michael Niedermayer encoded:
> > On Wed, May 09, 2012 at 01:35:47AM +0200, Stefano Sabatini wrote:
> > > Do not skip chapter header/footer printing, which breaks the parsing for
> > > most writers.
> > > ---
> > >  ffprobe.c |   26 +++++++++++++-------------
> > >  1 files changed, 13 insertions(+), 13 deletions(-)
> > 
> > this breaks fate
> > 
> > -format_name=mpeg
> > +[FORMAT]
> > format_name=mpeg
> > [/FORMAT]
> > Test probe-format-roundup1414 failed. Look at tests/data/fate/probe-format-roundup1414.err for details.
> > make: *** [fate-probe-format-roundup1414] Error 1
> > make: *** Waiting for unfinished jobs....
> > -format_name=dv
> > +[FORMAT]
> > format_name=dv
> > [/FORMAT]
> > TEST    prores-422_hq
> > -format_name=mp3
> > +[FORMAT]
> > format_name=mp3
> > [/FORMAT]
> > TEST    prores-422
> > Test probe-format-roundup1383 failed. Look at tests/data/fate/probe-format-roundup1383.err for details.
> > Test probe-format-roundup2015 failed. Look at tests/data/fate/probe-format-roundup2015.err for details.
> > make: *** [fate-probe-format-roundup1383] Error 1
> > make: *** [fate-probe-format-roundup2015] Error 1
> > -format_name=mpeg
> > +[FORMAT]
> > format_name=mpeg
> > [/FORMAT]
> > Test probe-format-roundup997 failed. Look at tests/data/fate/probe-format-roundup997.err for details.
> > make: *** [fate-probe-format-roundup997] Error 1
> 
> Hi, my plan is to update the fate code and have something like:
> -print_format default=w=0
> 
> I'll update the patch in order to avoid to break FATE.

Is OK to break fate for just one commit? Otherwise I'll have to add
and remove the data files (not a problem in se, but I'd prefer to
avoid that and save a bit of time).

See updated patch:
ffprobe: add "print_wrappers" option to default writer


More information about the ffmpeg-devel mailing list