[FFmpeg-devel] [PATCH] lavd/lavfi: remove unused code related to packing format negotiation

Stefano Sabatini stefasab at gmail.com
Wed May 16 00:33:07 CEST 2012


On date Tuesday 2012-05-15 22:24:41 +0200, Clément Bœsch encoded:
> On Tue, May 15, 2012 at 08:23:30PM +0200, Stefano Sabatini wrote:
> > ---
> >  libavdevice/lavfi.c |    2 --
> >  1 files changed, 0 insertions(+), 2 deletions(-)
> > 
> > diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c
> > index 0a6eb91..bdc5f58 100644
> > --- a/libavdevice/lavfi.c
> > +++ b/libavdevice/lavfi.c
> > @@ -211,11 +211,9 @@ av_cold static int lavfi_read_header(AVFormatContext *avctx)
> >                                                    AV_SAMPLE_FMT_S32,
> >                                                    AV_SAMPLE_FMT_FLT,
> >                                                    AV_SAMPLE_FMT_DBL, -1 };
> > -            const int packing_fmts[] = { AVFILTER_PACKED, -1 };
> >              const int64_t *chlayouts = avfilter_all_channel_layouts;
> >              AVABufferSinkParams *abuffersink_params = av_abuffersink_params_alloc();
> >              abuffersink_params->sample_fmts = sample_fmts;
> > -            abuffersink_params->packing_fmts = packing_fmts;
> >              abuffersink_params->channel_layouts = chlayouts;
> >  
> >              ret = avfilter_graph_create_filter(&sink, abuffersink,
> 
> Can't this be squashed with the other one?

Uhm OK, so patch dropped.
 
> Also, grepping AVFILTER_PACKED raised tools/lavfi-showfiltfmts.c which
> you might want to update as well with the other patch.

Noted.
-- 
FFmpeg = Freak and Funny Merciless Problematic Elitist Ghost


More information about the ffmpeg-devel mailing list