[FFmpeg-devel] [PATCHv3] lavf: add av_guess_frame_sample_aspect_ratio function

Joakim Plate elupus at ecce.se
Thu May 17 11:36:13 CEST 2012

>> No further comments received, please apply the v3 patch.
> locally applied, will be in my next push

Damn.. :). Missed updates here.

You have declared function as:

AVRational av_guess_sample_aspect_ratio(AVFormatContext *format,
AVStream *stream, AVFrame *frame)

This makes it hard to use the function if there is no AVFrame. (ie
directly after av_find_stream_info). Secondly i may be blind, but i
can't see that you use the format pointer at all in the function. Was
that just for future safety?


More information about the ffmpeg-devel mailing list