[FFmpeg-devel] [PATCH 3/3] vf_overlay: rewrite request/push logic.

Nicolas George nicolas.george at normalesup.org
Sun May 20 21:21:57 CEST 2012

Le primidi 21 floréal, an CCXX, Stefano Sabatini a écrit :
> nit: mainpicref?

Ok for mainpic, but the only way we ever access an AVFilterBuffer is through
a Ref, so the ref is really useless (and I would like to remove it more or
less everywhere for consistency).

> nit: i'd say next_overpicref, makes clear the relation with overpicref

Same as above: changed to next_overpic.

> Please comment these macroblocks, so it is much easier to read the
> code.


> My head spins when I can't say if a variable refers a queue, a pad or
> a picref, I suggest next_main -> next_mainpicref, yes it should be
> obvious by the "next_" but I prefer some redundancy to help my brain
> circuits to focus (especially at 2:30 in the morning).

Add pic.

> so this is, try again if there is not still a next mainpicref in the
> main queue, or try_start_again() can't provide a new outpicref.

Added a comment.

> unrelated?

Possible. But is it really worth it to make the history more complex just
for a trivial change like that while the file as a whole changes completely?

> nit++: stray newline


> nit: link->outlink

Changed, although I do not see the point.

> nit: r->ret


> reminds me that I have a patchset for this somewhere

Consider yourself reminded.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120520/aa7ecd59/attachment.asc>

More information about the ffmpeg-devel mailing list