[FFmpeg-devel] [PATCH 2/3] lavfi: add a generic API for buffer queues.

Nicolas George nicolas.george at normalesup.org
Sun May 20 21:25:53 CEST 2012


Le primidi 21 floréal, an CCXX, Stefano Sabatini a écrit :
> Nit: Generic AVFilterBufferRef queue

Changed.

> > +    unsigned short available;
> nb_available_bufs?

This is already scoped by the structure. IMHO it would only make lines
longer.

> "get" is quite confusing, "peek" seems less ambiguous and should be
> consistent with the lavu/fifo and lavfi/buffersink API.

> take->get? Consistent with buffersink/src.

Changed both.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120520/ceba1bb6/attachment.asc>


More information about the ffmpeg-devel mailing list