[FFmpeg-devel] [PATCH] Fix warnings about int64toint32conversion
mbradshaw at sorensonmedia.com
Mon May 21 21:09:53 CEST 2012
On Mon, May 21, 2012 at 12:12 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Michael Bradshaw <mbradshaw <at> sorensonmedia.com> writes:
>> I have tested this with gcc 4.2.1 with a random sampling
>> of 1000000 integers, and the output is the same before
>> and after the patch.
> Sorry for being unclear:
> I meant: Does your patch change the compiler output (when
> compiling FFmpeg) for any (supported) compiler / gcc 4.2.1?
Ah, of course, I should've check that. Yes, using gcc 4.2.1 I get the
exact same assembly before and after the patch.
Don: I still can't reproduce the warning in av_cmp_q with the latest
ffmpeg source... I have no idea why you can and I can't...
After thinking about it, I don't think I'll make another patch that
fixes the 4 new warnings when compiling with W4 unless there more
demand for these 4 other warnings to be fixed. W3 is the default
warning level for Visual Studio, and I think we should make ffmpeg
warning-less with the W3 level (which my second patch does (for me at
least; apparently not for Don though)). I fix the warnings for W4, I
might as well fix the even more warnings for /Wall, which I don't
really care to do unless someone has a request for this to be done.
I'll leave my second patch as my final version, if it's approved,
unless there's demand for warnings with /W4 or /Wall to be fixed too.
Don, sorry I can't reproduce.
More information about the ffmpeg-devel