[FFmpeg-devel] [PATCH]AVUI encoder

Michael Niedermayer michaelni at gmx.at
Wed May 23 13:04:52 CEST 2012

On Wed, May 23, 2012 at 07:27:15AM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> > > > > I wonder if the user should be able to set interlaced or not instead
> > > > > of relying on AVFrame->interlaced_frame.
> > > 
> > > No comment?
> > 
> > ahh, yes, the way AVFrame->interlaced_frame is used is not good
> What do you suggest?
> (I can simply set interlaced to 0 if that is better.)

you can use field_order
also the extradata malloc leaks as its allocated per frame

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120523/a3abd3f7/attachment.asc>

More information about the ffmpeg-devel mailing list