[FFmpeg-devel] [PATCH 2/4] mxfenc: support 50 and 60 frame rates

Michael Niedermayer michaelni at gmx.at
Thu May 31 16:53:51 CEST 2012


On Thu, May 31, 2012 at 02:10:22PM +0200, Tomas Härdin wrote:
> On Thu, 2012-05-31 at 14:02 +0200, Matthieu Bouron wrote:
> > On Thu, May 31, 2012 at 01:36:18PM +0200, Tomas Härdin wrote:
> > > On Sun, 2012-05-27 at 14:21 +0200, Matthieu Bouron wrote:
> > > > ---
> > > > $title
> > > > ---
> > > >  libavformat/mxfenc.c |   14 ++++++++++++--
> > > >  1 file changed, 12 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> > > > index b2ef1f3..1d11bae 100644
> > > > --- a/libavformat/mxfenc.c
> > > > +++ b/libavformat/mxfenc.c
> > > > @@ -44,8 +44,10 @@
> > > >  #include "internal.h"
> > > >  #include "mxf.h"
> > > >  
> > > > -static const int NTSC_samples_per_frame[] = { 1602, 1601, 1602, 1601, 1602, 0 };
> > > > -static const int PAL_samples_per_frame[]  = { 1920, 0 };
> > > > +static const int NTSC_samples_per_frame[]    = { 1602, 1601, 1602, 1601, 1602, 0 };
> > > > +static const int NTSC_60_samples_per_frame[] = { 801, 801, 801, 801, 0 };
> > > 
> > > Shouldn't this be something like "{ 801, 801, 801, 801, 800, 0 };"?
> > > 48000/60000*1001 = 800.8 after all..
> > > The rest looks fine.
> > > 
> > 
> > Indeed ! Thanks for pointing that out.
> > Patch updated
> 
> Looks OK to me.

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120531/ee1875ff/attachment.asc>


More information about the ffmpeg-devel mailing list