[FFmpeg-devel] [PATCH 1/2] lavu/opt: fix av_opt_get_key_value() API.

[Michael Niedermayer]

On Sat, Nov 10, 2012 at 01:17:39PM +0100, Nicolas George wrote:
> Add an argument to return the final delimiter.
> This is an API break, but the function was introduced only
> a week ago.

doesnt ropts already point to the delimiter after the function ?

[...]
>  API changes, most recent first:
>  
> -2012-11-02 - xxxxxxx - lavu 52.4.100 - opt.h
> +2012-11-11 - xxxxxxx - lavu 52.6.100 - opt.h
>    Add av_opt_get_key_value().

> +  (initialy added in lavu 52.4.100 with a different API)

I dont think this is usefull to document,
i just imagine if every change we did in a few days after adding a
new function was documented that way the file would be full of
irrelevant "oops i forgot documenting this or oops i had y typo there"

thus IMHO just refer to the date when the corrected version was added
but dont count this as a objection, its more my oppinion ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121112/c49da9c9/attachment.asc>