[FFmpeg-devel] [PATCH 4/4] lavfi/drawtext: implement more generic expansion.

Nicolas George nicolas.george at normalesup.org
Thu Nov 15 17:12:22 CET 2012


Le quintidi 25 brumaire, an CCXXI, Stefano Sabatini a écrit :
> Reminder: bump micro.

Added in the commit message. Odds are I'll forget it there :)

> Nit: this is a bit weird since it will result the only filter with
> that section (syntax is usually described just after the description).  

Well, this is the only filter that has such a long syntax section.

> Should be "@}" ?

Fixed.

> Add something along the lines: "and thus is strongly encouraged" so
> you get less users running and crying in the night because of escaping
> madness.

Muf. I do not think this is the place for that.

> Note: from my local texinfo manual:
> |Use the `@commannd' command to indicate command names, such as `ls' or
> |`cc'.
> (The typo is in the manual.) On the other hand same ad-hocity can be
> found in the definition of @option (Use the `@option' command to
> indicate a command-line option; for example, `-l' or `--version' or
> `--output=FILENAME') so this might be a valid choice and equivalent
> from the rendering point of view.

I believe texinfo is heavily biassed towards command-line utilities. I think
that @command is the most logical (the lest illogical) choice, and the
output looks ok.

> Maybe "time" or "pts_time" would be more appropriate, so it is still
> possible to use "pts" for indicating the actual timestamp (the PTS
> integer value), which might be useful for several (mostly debugging)
> reasons.

I agree that the exact integer PTS can be useful too, but it can be done
using an argument to the pts function, %{pts:i}, for example, or %{pts:6i}
to format it on six decimals. It seems more practical than fiddling with the
function name.

> What about to introduce an expansion_mode for this? So we could have:
> expansion=strftime -> deprecated, enabled by default for the moment
> expansion=extended
> expansion=literal
> 
> The latter would save jumps in the hoops when scripting.

Very good point, done.

> Thanks for working on this, this was on my todo since a long time but
> I couldn't find the motivation to find a proper and extensible design.

No problem, thanks for the review. New patch series incoming.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121115/350155aa/attachment.asc>


More information about the ffmpeg-devel mailing list