[FFmpeg-devel] [PATCH 4/4] lavfi/drawtext: implement more generic expansion.

[Nicolas George]

Le quintidi 25 brumaire, an CCXXI, Stefano Sabatini a écrit :
> expandS

Fixed.

> This may go in a separate paragraph, to stand out better and keep the
> previous normative paragraph short.

Changed.

> Needs to be updated.

Fixed.

> maybe "expansion" (I tend to prefer a noun in this context)

Ok.

> foo=foo is a bit ugly, what about expand=normal?

Ok.

> Nit+: add empty lines around the group, easier to get they stand together.

Ok.

> > +    { "pts",       0, 0, 0,   func_pts      },
> > +    { "localtime", 0, 1, 'L', func_strftime },
> what's "tag" good for?

The idea is to be able to add:

+    { "gmtime", 0, 1, 'G', func_strftime },

with the same implementation (most of the code would be identical), and be
able to check on tag to distinguish the cases:

    if (tag == 'L')
	localtime_r(&now, &tm);
    else
	gmtime_r(&now, &tm);

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121117/b18c69ab/attachment.asc>