[FFmpeg-devel] [PATCH 4/4] lavfi/drawtext: implement more generic expansion.

[Nicolas George]

Le septidi 27 brumaire, an CCXXI, Stefano Sabatini a écrit :
> Nit: I'm not sure what "change" refers here.

Changed to "conflict".

It means that you will not get a warning for "drawtext='Hello World!'", but
you will get a warning for "drawtext='%H:%M'", because of the %.

> Needs to be updated.

Hopefully all fixed.

> > +Sequence of the form @code{%@{...@}} are expanded. The text between the
> Note: my version of texi2html is broken and doesn't de-escape "@}", I
> have a local fix (yet to send) but right now this mean we will render
> broken output

The version in Debian (1.82-1 for both stable and unstable) works. And not
escaping } produce a broken output. I do not see a better solution.

> I'm still a bit befuddled by "tag", documenting the field may help
> with it, since currently the field is never used and it is no clear
> how it could be used/specified (the other option is to remove it
> altogether, until we have no use for it).

I added a short comment and implemented gmtime (at some point, we will need
to cleanup somewhat the localtime/localtime_r code duplication, and at the
same time add checks for gmtime_r, but that is for later).

> LGTM otherwise, thanks.

New patch sent.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121118/f5b49881/attachment.asc>