[FFmpeg-devel] [PATCH] swr: general doxy text about swr and example code.

[Clément Bœsch]

On Tue, Nov 20, 2012 at 09:13:09PM +0100, Michael Niedermayer wrote:
[...]
> > > > > + *  conversion context and everything associated with it must be freed with
> > > > > + *  swr_free().
> > > > > + */
> > > > >  
> > > > >  #include <inttypes.h>
> > > > 
> > > > unrelated: stdint.h is not enough?
> > > 
> > > My principle with headers is, add if compile fails, its not failing.
> > > Iam quite sure though we could invest time to make the includes a
> > > tighter subset which then will cause failures and the need to add more
> > > inlcudes earlier on future changes ...
> > > In the end this smells like work to add more work.
> > 
> > In this particular case of a public header I think it's important to keep
> > it clean for apps willing to do such "work". This header just needs
> > [u]int*_t types for prototypes, it looks pretty safe to just include
> > stdint.h.
> 
> feel free to change it
> 

Done.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121120/d27377c5/attachment.asc>