[FFmpeg-devel] [PATCH] swscale: fix To{Y, UV} extern prototypes.

Clément Bœsch ubitux at gmail.com
Mon Oct 1 00:20:23 CEST 2012

On Sun, Sep 30, 2012 at 03:11:10PM -0700, Ronald S. Bultje wrote:
> >> > > AFAIU, those prototypes were simplified by libav but it seems they were kept
> >> > > unchanged in FFmpeg (because of a bug? because the prototypes could be shared
> >> > > with the others functions?). Though, it might be important to check the if the
> >> >
> >> > the prototypes where the same originally, the additional fields
> >> > where added by me to support planar RGB (packed was fine with 1 pointer
> >> > but planar needed 3)
> >> > libav later reimplemented planar rgb support by adding a seperate
> >> > function pointer that takes 3, leaving the existing with 1 and adding
> >> > a if() to all calls
> >>
> >> Wouldn't it make sense to keep them in sync?
> >
> > in sync with libav? to simplify merge work?
> > that makes only sense when libav will continue to work on sws and
> > there is something to merge ...
> > and recent rumors dont point in that direction.
> > that said we certainly can switch to the 2 fptr API. And we certainly
> > should integrate all improvments anyone does on a swscale fork or
> > another scaler.
> See, it's these kind of statements, so full of utter arrogance, that
> make me actually want to do the libswscale fork/rework.

I believe there is a misunderstanding: we kind of understood Libav was
willing to rewrite from scratch sws (so no more sws contribution from
Libav), this is the reason the possibility of diverging was considered.

> I could
> probably be convinced at some level that it should be done in swscale,

"it"? AFAIU we are talking about a feature integrated differently in both

> but why on earth would I care if this is the best I get in response
> for all my efforts?

I think you misunderstand the statements made, and/or the ton. What are
you exactly angry about here?


Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121001/de418c9b/attachment.asc>

More information about the ffmpeg-devel mailing list