[FFmpeg-devel] [PATCH 1/2] Fix DPX decoder Rewrite the DPX decoder to work with provided sample DPXs

Michael Niedermayer michaelni at gmx.at
Fri Oct 5 05:05:56 CEST 2012

On Fri, Oct 05, 2012 at 01:14:05AM +0200, Georg Lippitsch wrote:
> Am 05.10.2012, 00:14 Uhr, schrieb Michael Niedermayer <michaelni at gmx.at>:
> >i dont remember the case you refer to so i cant comment on that,
> >but in general
> >
> >patches should be self contained, that is 1 bugfix = 1 patch,
> >1 feature = 1 patch
> >when in doubt its probably better to split, it can help with
> >git bisect later.
> I'm referring to: <20120502000050.GH2246 at arborea>
> (Subject: [PATCH] FireWire DV/HDV input device using libiec61883)
> Since DPX is a relatively simple format, I'd consider "DPX decoding"
> as one feature, and DPX encoding as another, so IMHO it's ok what I
> did.
> But of course I can split them into more parts if you want.

the purpose behind spliting commits is to make them easiert to review
and the results of git bisect more usefull.

if there are 3 commits each fixing one issue and in a month we notice
a problem we can bisect it down to the specific commit of the 3
that caused it. An example would be a slowdown or a breakage on
big endian. If its all one big commit then the result of bisect is
less specific and needs more manual work to debug

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121005/2f1bb957/attachment.asc>

More information about the ffmpeg-devel mailing list