[FFmpeg-devel] [PATCH] rename time.h to avtime.h
stefasab at gmail.com
Sun Oct 7 14:54:36 CEST 2012
On date Sunday 2012-10-07 14:40:09 +0200, Reimar Döffinger encoded:
> Nicolas George <nicolas.george at normalesup.org> wrote:
> >The second issue should be reported to the Android project developers.
> >I am
> >not opposed to adding workarounds for foreign bugs, but before that, I
> >like to see genuine efforts to fix the bug in the correct place, as it
> >require less maintenance for ffmpeg and fix things for other projects
> >When the Android developers have stated that, against all evidence,
> >they are
> >doing The Right Thing and What Users Expect and closed the bug as
> >that is another story.
> >On the technical side, leaving "time.h" there with just "#include
> >in it may fix the API stability issue.
> I think we can in principle rename it in git and just install it
> under both names to avoid an API issue for most.
Does it fix the problem if we have both? When the Android build
includes time.h (supposing the libc standard lib header), it may still
include the libavutil/time.h in libavutil, since it may give priority
to the one in libavutil.
Note: I am not against the rename if someone insists with it and/or
there is a need (and yes we agree that avtime.h was a better choice in
the first place), but again having libavutil/time.h should not be a
problem with a sane build system.
FFmpeg = Formidable Fundamental Mastodontic Pacific Enlightened Ghost
More information about the ffmpeg-devel