[FFmpeg-devel] [PATCH] Carry DV field order from decoder to encoder

Michael Niedermayer michaelni at gmx.at
Mon Oct 15 18:46:00 CEST 2012

On Mon, Oct 15, 2012 at 05:41:47PM +0200, Tomas Härdin wrote:
> Hi
> This patch series parses/writes the FS flag in the VSC pack for DV.
> An open question is what to do if the FF flag isn't set. This means the
> field specified by the FS flag should be duplicated. Currently this is
> silently ignored. We could nag, or handle it properly (lots of code).
> See [1]. I don't have a sample for this.
> About this patch, the field order won't be probed properly in the next
> patch unless this one is applied first. This probably has to do with
> threading - I don't really care.

"I dont really care" is not an acceptable explanation for patches.
In this case its about the order of read vs write, it works better
to write first than to read first, thus patch applied



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121015/3943d8cf/attachment.asc>

More information about the ffmpeg-devel mailing list