[FFmpeg-devel] [PATCH 1 of 3] movenc: enable writing of interlace information back to the 'fiel' atom. (2nd Version)

Tomas Härdin tomas.hardin at codemill.se
Fri Oct 26 13:34:30 CEST 2012

> +    /* If field_order has set by the coder to indicate interlace coding
> +     * update value to reflect current coded top_field_first status */
> +    if ((track->enc->coded_frame) && (track->enc->field_order > AV_FIELD_PROGRESSIVE))

Useless parentheses

> +            track->enc->field_order = track->enc->coded_frame->top_field_first ? AV_FIELD_TB:AV_FIELD_BT;

Shouldn't those be AV_FIELD_TT and AV_FIELD_BB? TB/BT are for when the
fields need to be displayed in reverse order to how they are encoded.

This highlights two issues I have with field_order in AVCodecContext: it
belongs in AVStream. AVCodecContext's field_order should only say what
field order the essence has.


More information about the ffmpeg-devel mailing list