[FFmpeg-devel] [PATCH 6/6] ffplay: increase sample array buffer

Marton Balint cus at passwd.hu
Thu Sep 6 23:40:51 CEST 2012

A decoded and resampled audio frame may not fit in the current size which is
not handled by the current code causing out of order waveform displays or even
channel mixups. A todo is added because this part can certainly be improved to
consume less memory but work reliably for any frame size.

Signed-off-by: Marton Balint <cus at passwd.hu>
 ffplay.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/ffplay.c b/ffplay.c
index 6a9349e..42f03b8 100644
--- a/ffplay.c
+++ b/ffplay.c
@@ -82,7 +82,8 @@ const int program_birth_year = 2003;
 #define AUDIO_DIFF_AVG_NB   20
 /* NOTE: the size must be big enough to compensate the hardware audio buffersize size */
-#define SAMPLE_ARRAY_SIZE (2 * 65536)
+/* TODO: We assume that a decoded and resampled frame fits into this buffer */
+#define SAMPLE_ARRAY_SIZE (8 * 65536)
 static int sws_flags = SWS_BICUBIC;

More information about the ffmpeg-devel mailing list