[FFmpeg-devel] [PATCH 3/3] random_seed: Replace a VLA with a heap alloc

Derek Buitenhuis derek.buitenhuis at gmail.com
Fri Sep 7 19:42:44 CEST 2012

On 07/09/2012 1:35 PM, Michael Niedermayer wrote:
> i would suggest
> uint8_t tmp[120];
> ...
> av_assert0(sizeof(tmp) >= av_sha_size)
> this would be simpler and completely avoid variable allocation

Wouldn't this be duplicating av_sha_size? I'm not against it, but
in general, I am wary of duplicated numbers like this.

BTW, why is av_sha_size not a constant/define anyway?

- Derek

More information about the ffmpeg-devel mailing list