[FFmpeg-devel] [PATCH 3/4] lavf/segment: Rename variable in print_csv_escaped_str()
stefasab at gmail.com
Sat Sep 15 14:41:51 CEST 2012
On date Saturday 2012-09-15 12:42:53 +0200, Alexander Strasser encoded:
> Hi Stefano,
> Stefano Sabatini wrote:
> > On date Saturday 2012-09-15 01:07:56 +0200, Alexander Strasser encoded:
> > > Rename a local variable to make the code more self-explanatory.
> > >
> > > Signed-off-by: Alexander Strasser <eclipse7 at gmx.net>
> > > ---
> > > libavformat/segment.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/libavformat/segment.c b/libavformat/segment.c
> > > index 07b8da3..fbfd677 100644
> > > --- a/libavformat/segment.c
> > > +++ b/libavformat/segment.c
> > > - if (quote)
> > > + if (needs_quoting)
> > > avio_w8(ctx, '"');
> > > }
> > LGTM if you prefer like that..
> This change was inspired by your remark to add a comment. I am not
> that fond of adding another comment there. But I concluded that the name
> of that variable is quite broad (and could easily be mis-interpreted).
> So I guess I need to know if this is enough for you or you rather
> would like to have an additional comment or both?
I'm fine with either, do as you prefer.
FFmpeg = Fanciful Faithless MultiPurpose Eretic Geek
More information about the ffmpeg-devel